[Bug 195363] Review Request: esc and esc-xulrunner-devel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





------- Additional Comments From rstrode at redhat.com  2006-07-25 22:51 EST -------
It looks like the spec and package moved to 

http://directory.fedora.redhat.com/built/rpm_review/jmagne/

yea? Looking good.  A few things:

- The gtk-update-icon-cache stuff still isn't right.  Have a look at
http://fedoraproject.org/wiki/ScriptletSnippets for the right idiom.

- you don't have to manually run tar for xulrunner, you can specify another
%setup line, although I don't remember the right arguments to give it off hand.

- Also, I don't think you should need %{_buildir} anywhere. rpm normally puts
you in the right directories i think.

- I think if you just put %doc esc/LICENSE in the filelist then it should get
moved to the right place (/usr/share/doc/esc-1.0.0/LICENSE) automatically, but I
could be wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.