[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-07-27 19:22 EST -------
Source: %{tmppath}/SOURCE/%{name}-%{version}-%{release}.tar.gz

No!

Source: %{name}-%{version}.tar.gz or the URL link from the website (eg
http://www.foo.org/package/download/com-1.1.1.tar.gz)

remember, the source is the source you've downloaded from the website the
package came from (unless you've built the archive yourself, which is not that
good an idea, especially if you have patches. You should keep the source
unpatched and provide patches which are incorporated via the spec file)

Please package again. The src rpm will include the patches, the spec file will
apply them in %prep - I can't accept it as is.

Can you put the defines right at the start? - it makes things much simpler to
follow. 

Given the specs, it's unlikely this will work in FC5 (unless things are updated
in FC5). I'd drop the versions from the Requires.

mkdir -p $RPM_BUILD_ROOT%{python_sitelib}/jokosher
mkdir -p $RPM_BUILD_ROOT%{python_sitelib}/jokosher/images
mkdir -p $RPM_BUILD_ROOT%{python_sitelib}/jokosher/Instruments
mkdir -p $RPM_BUILD_ROOT%{python_sitelib}/jokosher/Instruments/images

You only need the final line and the images line. -p creates the path requested

--mode=644, much easier just to have -m 0644

install -d $RPM_BUILD_ROOT%{python_sitelib}/jokosher/images

Not sure these are required as you've already created the directories

install -p jokosher $RPM_BUILD_ROOT%{_bindir}/jokosher
chmod 755 $RPM_BUILD_ROOT%{_bindir}/jokosher

can be written

install -p -m 0755 jokosher $RPM_BUILD_ROOT%{_bindir}/jokosher

Why have you got BR desktop-file-utils, but never use them. What are they for?

Still a way to go, but keep on in there.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.