[Bug 198885] Review Request: perl-POE-Component-Client-HTTP
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jul 28 00:18:34 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Component-Client-HTTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198885
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-07-27 20:09 EST -------
I did try via spectool to fetch the 0.76 source about ten times but never
succeeded in hitting a mirror that had it. Now that this package is updated to
0.77 there are no worries.
Anyway, this builds, installs and checks out fine.
* source files match upstream:
bca2c306d8c63535845b760883a13644 POE-Component-Client-HTTP-0.77.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is redundant).
* %clean is present.
* package builds in mock (development, x86_64).
* noarch package; no debuginfo.
* rpmlint is silent.
* final provides and requires are sane:
perl(POE::Component::Client::HTTP) = 0.77
perl(POE::Component::Client::HTTP::Request)
perl(POE::Component::Client::HTTP::RequestFactory) = 0.01
perl(POE::Filter::HTTPChunk)
perl(POE::Filter::HTTPHead) = 0.01
perl(POE::Filter::HTTPHead_Line)
perl-POE-Component-Client-HTTP = 0.77-1.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(HTTP::Response)
perl(HTTP::Status)
perl(POE)
perl(POE::Component::Client::HTTP)
perl(POE::Component::Client::HTTP::Request)
perl(POE::Component::Client::HTTP::RequestFactory)
perl(POE::Filter::Line)
perl(base)
perl(bytes)
perl(strict)
perl(vars)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=12, Tests=76, 5 wallclock secs ( 2.12 cusr + 0.66 csys = 2.78 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list