[Bug 212856] Review Request: php-pear-Pager - Data paging class

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 6 16:32:12 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Pager - Data paging class
Alias: php-pear-Pager

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212856





------- Additional Comments From Fedora at FamilleCollet.com  2006-11-06 11:32 EST -------
* source files match upstream:
9dd1fd0aee0e8039f1a4033f822d50c3  Pager-2.4.2.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (BSD)
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
  php-pear(Pager) = 2.4.2
  php-pear-Pager = 2.4.2-1.fc6
* %check is not present; see comment
* owns the directories it creates
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Example provided work fine.
I've don't find how to run test-suit (even with simpletest installed) ??

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list