[Bug 212704] Review Request: manedit - UNIX Manual Page Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: manedit - UNIX Manual Page Editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212704





------- Additional Comments From pertusus at free.fr  2006-11-10 05:45 EST -------
The spec file seems right to me, however I have spotted some compilers
warnings that are worrisome, and for some of them certainly easy to
fix:

There are many warnings about signedness:
pointer targets in passing argument 2 of '__builtin___strncpy_chk' differ in
signedness
I think this could be investigated. I don't know exactly what is the
potential impact of such warnings, but I guess in some cases there
is room for trouble.

Some include files are certainly not used as they should, I think this 
should be fixed, as it is easy to fix and it may uncover other issues:
editor.c:199: warning: implicit declaration of function 'memcpy'
editor.c:199: warning: incompatible implicit declaration of built-in function
'memcpy'

There are also these warnings:
editorop.c:1146: warning: ignoring return value of 'mkstemp', declared with
attribute warn_unused_result
maneditop.c:566: warning: ignoring return value of 'mkstemp', declared with
attribute warn_unused_result
viewerfio.c:177: warning: ignoring return value of 'mkstemp', declared with
attribute warn_unused_result
viewerfio.c:181: warning: ignoring return value of 'mkstemp', declared with
attribute warn_unused_result

And lastly (but maybe this should be better sent upstream)
prefop.c: In function 'PrefDoApply':
prefop.c:107: warning: 'gdk_color.pixel' is used uninitialized in this function



There are other warnings, but they don't seem to be problematic 
to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.