[Bug 190213] Review Request: gq - Graphical LDAP directory browser and editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gq - Graphical LDAP directory browser and editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190213





------- Additional Comments From terjeros at phys.ntnu.no  2006-11-20 10:35 EST -------
> You should change it to Patch0: anyway, since it's the first patch. Same for
> Source: and Source01:, should be Source0: and Source1: instead.

Fixed.
 
> FAIL - package doesn't build in mock, an error occurs while building the locales:
> You need to BuildRequire gettext to provide msgfmt.

Fixed.
 
> FIX - Remove the line about desktop-file-utils from changelog entry of 1.2.1-3.
> The line is wrong, desktop-file-utils is still included in your spec and this is
> correct. Simply drop that line.

Fixed.
 
> FIX - Although the package builds in mock you should add a buildrequirement on
> libgcrypt-devel (configure checks for /usr/bin/libgcrypt-config)

Fixed.

> MINOR - After you have removed useless macros you can also replace "%{__cp} -p"
> with a simple "cp" (when copying LINGUAS)

Fixed.
 
> MINOR - IMHO %post and %postun should not be after the %files section

Fixed.
 
> MINOR - You can make %post and %post un a little smarter
> 
> > %post -p update-mime-database %{_datadir}/mime &> /dev/null || :
> >
> > %postun -p update-mime-database %{_datadir}/mime &> /dev/null || :
> 
> This has the advantage the rpm will automagically care for the requirement on
> update-mime-database/shared-mime-info

I am able to don't get this to work, should it?

New files:
SPEC:  http://www.pvv.org/~terjeros/rpms/gq/gq.spec
SRPMS: http://www.pvv.org/~terjeros/rpms/gq/gq-1.2.2-2.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.