[Bug 174377] Review Request: gnu-smalltalk - GNU Smalltalk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnu-smalltalk - GNU Smalltalk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-11-26 22:11 EST -------
Well, very quick look at this:
* Why isn't %configure macro used in spec file?
* Is exporting 'CCFLAGS' variable required?
* make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
  The description CFLAGS="$RPM_OPT_FLAGS" is not needed when %configure
  macro is used.
* -devel package should not require ldconfig call.
* %{_bindir}/gst-config
  The content of this file is incorrect as this contains 
---------------------------------------------
gst_libs='@LDPATH@ -lnsl -lm '
----------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.