[Bug 191743] Review Request: sysprof - a sampling CPU profiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sysprof -  a sampling CPU profiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191743





------- Additional Comments From panemade at gmail.com  2006-10-03 05:36 EST -------
Review:
+ package builds in mock (development i386).
+ source files match upstream.
8949fe32a073b84cb2abb7f9d608f755  sysprof-1.0.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ BuildRequires are proper.
+ %clean is present.
+ package installs properly
+ rpmlint is silent.
+ Provides: sysprof-kmod-common = 1.0.3
+ Requires: kmod-sysprof >= 1.0.3 
libatk-1.0.so.0 
libc.so.6 
libc.so.6(GLIBC_2.0) 
libc.so.6(GLIBC_2.1) 
libc.so.6(GLIBC_2.2.3) 
libc.so.6(GLIBC_2.3.4) 
libc.so.6(GLIBC_2.4) 
libcairo.so.2 
libdl.so.2 
libdl.so.2(GLIBC_2.0) 
libdl.so.2(GLIBC_2.1) 
libgdk-x11-2.0.so.0 
libgdk_pixbuf-2.0.so.0 
libglade-2.0.so.0 
libglib-2.0.so.0 
libgmodule-2.0.so.0 
libgobject-2.0.so.0 
libgthread-2.0.so.0 
libgtk-x11-2.0.so.0
libm.so.6 
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
libpthread.so.0 
libpthread.so.0(GLIBC_2.0) 
libxml2.so.2 
libz.so.1 
rtld(GNU_HASH)

+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ documentation is small, so no -docs subpackage is necessary.
+ Not a GUI app

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.