[Bug 209082] Review Request: scanbuttond - Scanner Button tools to SANE

Wed Oct 4 11:43:08 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scanbuttond - Scanner Button tools to SANE

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209082

------- Additional Comments From jima at beer.tclug.org  2006-10-04 07:43 EST -------
> Thanks for solving rpmlint errors.

No problem.  They had me pretty confused, too, so don't feel too bad.  I ended
up extracting the files using `rpm2cpio scanbuttond-0.2.3-2.fc6.i386.rpm | cpio
-id` and just eyeballing things.  (`rpm -qpl` *should* have given me enough
hint, but I wasn't seeing it.)  I knew there had to be something odd to throw
off rpmlint. :-)

> Need your suggestions whether to create a patch or let package as it is now.

Nah, your methodology is better for this case, especially with the reasoning
you're using.  My chain of thought was a bit idealistic.

The only other thing that comes to mind (mainly by your idea to let the user
provide their own buttonpressed.sh script) is that you might want to explicitly
refer to that file with a %config(noreplace) tag, so that if the user edits the
file after installation, it doesn't get blown away, should there be an update
(or they upgrade to the next Core release).  Don't worry about it right now;
wait until after I do a full work (once I get to the office today).  Just
something to consider.

Also, you don't need to attribute my changes to me in your final spec; I only
updated the changelog to ennumerate what I changed. :-)