[Bug 208424] Review Request: scrot - Screen-shot capture using Imlib2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scrot -  Screen-shot capture using Imlib2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208424


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |bugs.michael at gmx.net




------- Additional Comments From bugs.michael at gmx.net  2006-10-04 08:23 EST -------
* Project home page URL is  http://linuxbrit.co.uk/scrot/
  (note the /scrot/ postfix)


* rpmlint scrot-0.8-1.fc5.src.rpm 
W: scrot non-standard-group Applications/Graphics

Better:  User Interface/X


* License is MIT -- not BSD.
  cf. http://www.opensource.org/licenses/mit-license.html


* rpmlint /home/qa/tmp/rpm/RPMS/scrot-0.8-1.i386.rpm
W: scrot non-standard-group Applications/Graphics
W: scrot no-version-in-last-changelog

Although rpmlint doesn't understand where you've put the "0.8"
version in the %changelog, you should add the release value in there,
too:

* Tue Sep 26 2006 Michael Rice <errr[AT]errr-online.com>
- 0.8-1
- Initial RPM release

Or:

* Tue Sep 26 2006 Michael Rice <errr[AT]errr-online.com> - 0.8-1
- Initial RPM release

Or:

* Tue Sep 26 2006 Michael Rice <errr[AT]errr-online.com> 0.8-1
- Initial RPM release


* Documentation duplicated because of a wrong %patch. Keep the
%doc lines in the spec, get rid of %_datadir/%name:

$ rpmls -p /home/qa/tmp/rpm/RPMS/scrot-0.8-1.i386.rpm
-rwxr-xr-x  /usr/bin/scrot
drwxr-xr-x  /usr/share/doc/scrot-0.8
-rw-r--r--  /usr/share/doc/scrot-0.8/AUTHORS
-rw-r--r--  /usr/share/doc/scrot-0.8/COPYING
-rw-r--r--  /usr/share/doc/scrot-0.8/ChangeLog
-rw-r--r--  /usr/share/doc/scrot-0.8/README
-rw-r--r--  /usr/share/doc/scrot-0.8/TODO
-rw-r--r--  /usr/share/man/man1/scrot.1.gz
drwxr-xr-x  /usr/share/scrot
-rw-r--r--  /usr/share/scrot/AUTHORS
-rw-r--r--  /usr/share/scrot/ChangeLog
-rw-r--r--  /usr/share/scrot/README
-rw-r--r--  /usr/share/scrot/TODO


* ./src/Makefile.am sets a bad INCLUDES line. First of all, standard
search path for headers should not be re-added with -I as this breaks
customised search paths. And second, be careful that in updates (or
other packages) the -O3 does never come after our global optflags.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.