[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034





------- Additional Comments From faucamp at csir.co.za  2006-10-04 08:43 EST -------
Ok, some review points:

* package meets naming and packaging guidelines; name uses mixed case, but since
you are the author, I assume this is quite intentional :-)
* latest version is being packaged
* source files match upstream:
ff1be8aa2cd0ad049e526958a626f07b  HippoDraw-1.18.6.tar.gz
* specfile is cleanly written 

* specfile does NOT use macros consistently ($RPM_BUILD_ROOT, ${RPM_BUILD_ROOT},
etc)

* dist tag is present
* build root is correct

* IMPORTANT: license is incorrect: you are licensing this as LGPL, but some
parts of this application are linking to Qt 3 (free edition), which is licensed
under the GPL; therefore this application must also be licensed as GPL.
Quoting the GPL:
   b) You must cause any work that you distribute or publish, that in
    whole or in part contains or is derived from the Program or any
    part thereof, to be licensed as a whole at no charge to all third
    parties under the terms of this License.

* %clean is present, but check consistency of RPM_BUILD_ROOT macros
* rpmlint is silent on .src.rpm
* package does NOT build in mock (FC-5, i386), see previous comments

Hope this helps!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.