[Bug 208424] Review Request: scrot - Screen-shot capture using Imlib2

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 4 17:42:30 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scrot -  Screen-shot capture using Imlib2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208424





------- Additional Comments From miker5slow at grandecom.net  2006-10-04 13:42 EST -------
Michael, thanks for going over this package for me. I have redone some things,
and now rpmlint is no longer giving any output. I think I have fixed all the
things you pointed out with the exception of 

* ./src/Makefile.am sets a bad INCLUDES line. First of all, standard
search path for headers should not be re-added with -I as this breaks
customised search paths. And second, be careful that in updates (or
other packages) the -O3 does never come after our global optflags.

I am not sure exactly what to do here with the Makefile.am  I also have no idea
what you mean about the -O3 Would you be able to provide me with some more input?

Thanks.

http://errr.fluxbox-wiki.org/fedora_stuff/scrot/2/scrot.spec
http://errr.fluxbox-wiki.org/fedora_stuff/scrot/2/scrot-0.8-2.fc5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list