[Bug 206836] Review Request: TurboJson - Python template plugin that supports json

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 5 04:09:06 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TurboJson - Python template plugin that supports json


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206836





------- Additional Comments From toshio at tiki-lounge.com  2006-10-05 00:09 EST -------
MD5Sums:
d8053e4b4e7920305bb6a96bfba23164  TurboJson-0.9.9-py2.4.egg
4d1d6e3bb323f2c01b374451606be7ae  python-turbojson.spec
71365a47c5c7ee71f3e3fcb93a2060bb  ../python-turbojson-0.9.9-1.src.rpm

Blockers:
* Upstream seems to have changed the download URL to:
  http://files.turbogears.org/eggs/TurboJson-0.9.9-py2.4.egg

Good:
* Package named according to the naming guidelines.
* Spec file name matches the package name.
* Package licensed under a MIT style license.
* The spec file is legible, American English.
* Source matches upstream.
* Package compiles and builds as noarch on an x86_64.
* All BuildRequires are satisfied.
* No locales.
* No shared libraries, static libraries, headers, or pkgconfig files.
* Not relocatable.
* Package owns all files and directories it creates.
* No duplicate files.
* Permissions properly set.
* Proper %clean section.
* Macros are properly used.
* No large docs.  Docs do not affect runtime.
* No GUI application.
* Does not own directories already owned.
* Builds in mock.
* Runs with a TurboGears-1.0-0.1.b1 created here and the python-turbokid
  submitted earlier.

rpmlint says:
  W: python-turbojson no-documentation
which can't be helped as upstream isn't providing any documentation yet.

This is APPROVED as long as you fix the Source URL when you import it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list