[Bug 208424] Review Request: scrot - Screen-shot capture using Imlib2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scrot -  Screen-shot capture using Imlib2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208424


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bugs.michael at gmx.net  2006-10-05 06:52 EST -------
* Eliminating redundant BuildRequires is _not_ a MUSTFIX item and
sometimes can be tiresome and not worthwhile:

./src/scrot.h contains _direct_ dependencies on X headers, so an X
-devel rpm in the BuildRequires makes sense (even if it may be
redundant in the complete dependency-chain).

There is no direct dependency on Imlib2, since giblib is a wrapper
library for it and giblib-devel "Requires: imlib2-devel" already.
"BuildRequires: imlib2-devel" can be removed safely.


* I agree that the README in %doc can be deleted. It is irrelevant to
the rpm package user and hasn't changed in six years. Same applies to
the TODO file, which contains nothing of interest. These files can be
excluded after importing the package to CVS, though. And note that for
more active software projects, it might happen that an upgrade adds
interesting contents to either README or TODO ;) and a packager might
forget about re-adding them.


* APPROVED: scrot-0.8-2.fc5.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.