[Bug 208051] Review Request: dirvish - Fast, disk based, rotating network backup system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dirvish - Fast, disk based, rotating network backup system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051





------- Additional Comments From tibbs at math.uh.edu  2006-10-05 12:07 EST -------
First off, the spec says GPL but the license in certainly not the GPL:
    Licensed under the Open Software License version 2.0
And as a bonus, v2.0 of that license shouldn't be used.  But I think it's still
open source; it was version 1.1 that had problems.

Also, the actual license needs to be included in the package, since it's present
in the tarball.

* source files match upstream:
   892ec9333b19e623880cdb499443c11b  dirvish-1.2.1.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.
X License text included upstream but is not in the final package.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is not necessary)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   dirvish = 1.2.1-1.fc6
  =
   /usr/bin/perl
   perl(File::Find)
   perl(Getopt::Long)
   perl(POSIX)
   perl(Time::ParseDate)
   perl(Time::Period)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.