[Bug 191492] Review Request: unuran-0.7.2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unuran-0.7.2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191492





------- Additional Comments From tibbs at math.uh.edu  2006-10-05 21:58 EST -------
A few issues I noticed.

The package won't install:
   /usr/share/info/dir from install of unuran-0.7.2-2.fc6 conflicts with file
from package info-4.8-11.1
You'll need to delete that file, or %exclude it.  This also causes a few rpmlint
warnings:
   E: unuran standard-dir-owned-by-package /usr/share/info
   E: unuran info-dir-file /usr/share/info/dir

You don't call install-info to properly install the info files.  See:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
   E: unuran postin-without-install-info /usr/share/info/unuran.info-2.gz
   E: unuran postin-without-install-info /usr/share/info/unuran.info-2.gz
   E: unuran postin-without-install-info /usr/share/info/unuran.info.gz
   E: unuran postin-without-install-info /usr/share/info/unuran.info.gz
   E: unuran postin-without-install-info /usr/share/info/unuran.info-1.gz
   E: unuran postin-without-install-info /usr/share/info/unuran.info-1.gz
   E: unuran postin-without-install-info /usr/share/info/dir
   E: unuran postin-without-install-info /usr/share/info/dir

These will go away when you fix the install-info bit:
   W: unuran one-line-command-in-%post /sbin/ldconfig
   W: unuran one-line-command-in-%postun /sbin/ldconfig

Headers and unversioned .so files need to be in a -devel subpackage:
   W: unuran devel-file-in-non-devel-package /usr/lib64/libunuran.so
   W: unuran devel-file-in-non-devel-package /usr/include/unuran_config.h

Finally, static libraries are not generally permitted at all.  Passing
--disable-static and removing the .a file from %files gets rid of it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.