[Bug 209614] Review Request: wmmemload - windowmaker dock app

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wmmemload - windowmaker dock app


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209614


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-10-07 04:58 EST -------
I don't have access to the .src.rpm.

I have many comments on the spec file (some are in fact blockers, some 
are really comments), though:

* I would personally have dropped 'for window managers such as WindowMaker'
  from the summary, since it will be shorter, and also those apps 
  are well suited to fluxbox, for example if I'm not wrong.
* the provide wmmemload is unusefull, it is automatically set by rpm
* The Epoch is not needed. In my opinion it is clearer if it is not 
  mentioned when set to 0
* the buildroot is not the preferred one
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1
  (although it has been agreed that %(%{__id_u} -n) could be removed).
* The Requires are not needed, there are picked up automatically by rpm
* BuildRequires: libX11-devel is optional since libX11-devel is required
  by libXext-devel or libXpm-devel
* export CFLAGS="$RPM_OPT_FLAGS" is unneeded, it is part of %configure
* if I'm not wrong, prefixing with %{_builddir}/%{name}-%{version}/ is 
  not needed in %install since it is what the current working directory 
  is set to.
* in %files, I think it is better to use
%{_mandir}/man1/wmmemload.1*
instead of
%{_mandir}/man1/wmmemload.1.gz
  to catch no compression and different compression schemes.
* in the changelog, I think the 0: corresponding with epoch is unneeded

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.