[Bug 204513] Review Request: xorg-x11-xcalc - X.org XCalc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-xcalc - X.org XCalc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204513





------- Additional Comments From pertusus at free.fr  2006-10-09 05:49 EST -------
* rpmlint warns only about the license, it may be ignored
* follows packaging and naming guidelines
* free software, with a precision on the file with a missing
  licence. No license file included, but there is none 
  upstream. 
* spec legible
* match upstream:
c1ecea85be15f746a59931e288768bdb  xcalc-X11R7.0-1.0.1.tar.bz2
* clean provides:
Provides: xorg-x11-xcalc = 1.0.1
  to match the name of other Xorg packages
* %files right
* a gui app, with icon and desktop file included

This is potentially approved whenever you get sponsored.
I am almost ready to sponsor you, since you shown you 
were ready to follow the guidelines, you have the required
skills. This was not a very difficult package, but the licence
issue was annoying and all the desktop stuff was missing.

If you just show some more interest in fedora extras
(as described in
http://fedoraproject.org/wiki/Extras/HowToGetSponsored)
I'll sponsor you.

I still have some comments on the package:

- in xcalc.desktop, the GenericName should better be along
  'Scientific Calculator' (like for kcalc) 'Calculator' or
  'Graphical Calculator'. (Could be changed after importing to CVS)
- maybe you could notice xorg about the license issue. Normally
  you should ask for a licence file inclusion, but in that 
  case I think that xorg allready knows that some split tarballs
  don't have a licence file.
- when I start I have warnings:
Warning: Missing charsets in String to FontSet conversion
Warning: Cannot convert string "-adobe-symbol-*-*-*-*-*-120-*-*-*-*-*-*" to type
FontStruct
  and the button corresponding with the square root is labelled 
ö`
  this may be a local configuration issue or a bug in fonts or resource
  file. Something that may be worth investigating, but not a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.