[Bug 209959] Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209959





------- Additional Comments From pertusus at free.fr  2006-10-09 09:24 EST -------
(In reply to comment #3)


> > * The Source0 should be an url. It seems to be
> > http://www.tenr.de/files/fluxmod-styles-pkg.tar.bz2
> This is not the same thing at all but I do plan to package these too so we will
> get the package name fixed there too.

Yep, I used the url just around the right one...


> > * %{_styledir}/ will be unowned.
> How is the best way to resolve this?

Either you have

%{_styledir}/

Or if you insist on having the glob (since it will error out if the 
directory is empty)

%dir %{_styledir}
%{_styledir}/*


> you dont want them can annoy you when you open the menu and get scrolled to
> where they are, because the submenu it makes will cover the whole screen area. I
> did include a README which has instructions for a user to add them to the menu.

After some thinking, it seems that the alternative would imply 
patching fluxbox-xdg-menu, which is not in the same package. Not
handy. Maybe a README is all what is needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.