[Bug 210061] Review Request: msyslog - A daemon for the syslog system log interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: msyslog - A daemon for the syslog system log interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210061


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-10-09 18:16 EST -------
* the version should be 1.08g, since it looks like a postrelease
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-18aa467fc6925455e44be682fd336667a17e8933

* the indenting is bad (not a blocker)

* initdir could be %{_sysconfdir}/rc.d/init.d, but both are
  arguable.

* -n %{name}-%{version} is unusefull, it is the default

* the patches and install section are complicated. I propose 
  simplified version and a corresponding spec file patch, I attach them.

* I also attach a patch to use user provided value for localstatedir
  and modify the pid file name.

* the daemon seems not to drop privileges without a patch posted
  on cvs. It should be applied and used in init, together with 
  the creation of a user and so on.

* libmsyslog.so.1.08g shouldn't be a static library, you should patch
  the Makefile.in or the like to have it compiled as a module.

* the stuff at the end of %post should rapidly be removed before
  somebody notice what you were trying to do ;-)

* libmysqlclient.so and libpq.so are dlopened in om_mysql.c and
  om_pgsql.c, that's bad. They should be linked.

Overall I am not convinced that this software is worth packaging in 
fedora. It seems to be unmaintained since 3 years, the build system is
very broken, there are non portable Makefiles, and dlopening the 
libraries seems very bad to me. You can try nevertheless if you 
like, but it will be a fair amount of work.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.