[Bug 209082] Review Request: scanbuttond - Scanner Button tools to SANE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scanbuttond - Scanner Button tools to SANE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209082





------- Additional Comments From rc040203 at freenet.de  2006-10-10 02:35 EST -------
Parag, I regret having to say this, but this package's packaging is pretty broken:

MUSTFIX:

/usr/bin/scanbuttond dlopens the  libscanbtnd-backend* libraries by name, using
the name libscanbtnd-backend*.so (Note: *.so, not *.so.1) rsp. by the name
specified in meta.conf (All set to *.so)

C.f. scanbuttond --help
and meta.conf inside of the sources.

Consequences:

1. Though the libscanbtnd-backend libs actually are shared libs, they are being
used as plugins to be dlopened by name, and not as normal shared libs.

=> Shipping the *.so.* in %{_libdir} doesn't make much sense.
=> The *.so must be part of the same package as scanbuttond, or the sources need
 to be patched to dlopen the *.so.1 instead of the *.so.

2. The *-devel package doesn't make sense, because the package does not provide
an API (header files) nor an API to load the plugins (it is hidden as private
files inside of scanbuttond.c and lib/loader.c)

Recommendation:
1. Remove the *-devel package

2. %configure --libdir=%{_libdir}/scanbuttond
This will cause the *.so* to land in %{_libdir}/scanbuttond instead of %{_libdir}

3. ship all %{_libdir}/scanbuttond/lib*.so as part of the main package.

4. Consider to modify the sources to dlopen(*.so.1) instead of *.so


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.