[Bug 210061] Review Request: msyslog - A daemon for the syslog system log interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: msyslog - A daemon for the syslog system log interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210061





------- Additional Comments From pertusus at free.fr  2006-10-10 03:03 EST -------
(In reply to comment #9)

> Thanks a lot for your efforts and suggestions, Patrice. What I liked most was
> your fix for x86_64. I had no idea about the make INSTALL_LIBDIR option, I guess
> that's my major lesson for today.

It is not something standard at all... In fact after noticing
that make variables where used for all the installed files, I removed
the DESTDIR patch and found the relevant make variables by looking
at the code each time I got an install error.

There is nothing standard in the build system of that package...
All seems to be hand made, but unfortunately some parts (like linking
libraries in a portable way) are better done with tools like libtool,
and the result is quite messy.

> Fast comments:
> - I have kept the version as defined by the developer. Actually during the first
> iterations I was using 1.08g (hence the setup -n), but switched back to the
> original after a talk with a developer friend (while trying to convince him to
> help me fix the dlopens). The funny part is that for the devel tree (1.9) the
> developer changed the convention used for naming the tar file :)

It is not very clear in the guidelines, but if the version is
numeric it is much easier to have an increasing ascii version, 
if it has letters (except for an increasing alphabetical postfix)
ensuring that the version increase in the ascii sense becomes 
harder to achieve. The 'internal' version is 1.08g, so it is certainly
better to use that, even though the tarball is named otherwise. 

> - I have removed the BSD part on purpose. We do not support/build for openBSD,
> do we ?

We don't but we shouldn't modify unused upstream code except when
it breaks something.

> - About the uglyness in %post: I know. Unfortunately I have not found any other
> way of getting rid of the dlopen effect without modifying the source files.

You'll have to :/. There is nothing in the guideline formally forbidding
dlopening although the library is always used, but I don't think you'll 
find any other fedora contributor who would accept the package with such
a wrong behaviour. Fortunately the way things are packaged forbids such 
misbehaviour by hidding the .so in -devel packages...

> - With one exception, all the man pages already have distinctive names (either
> starting with im_, om_ or with msyslog) and do not seem to clash with anything.
> Why do you suggest renaming them? Just to be able to locate where do they belong
> to from a first glance?

A man page like im_tcp is both too general, (a clash may appear
with another package for which the name is relevant), and hard
to find. I personnally wouldn't make that issue a blocker, but 
other reviewers may be stricter.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.