[Bug 209959] Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209959


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From pertusus at free.fr  2006-10-10 03:46 EST -------
* rpmlint has some warnings:
W: tenr-de-styles-pkg invalid-license Creative Commons Attribution-ShareAlike 2.5
W: tenr-de-styles-pkg no-%build-section
W: tenr-de-styles-pkg invalid-license Creative Commons Attribution-ShareAlike 2.5
E: tenr-de-styles-pkg script-without-shebang
/usr/share/tenr-de-styles-pkg-1.0/styles/monochrom2..3/theme.cfg

The licence and no-%build-section are ignorable, the error should be 
corrected, it comes from a wrong permission. Something like

chmod -x styles/monochrom2..3/theme.cfg

in %prep should do the trick.

* follow packaging and naming guidelines
* free licence for content, included
* spec simple and legible
* match upstream
758323157d8a8fb98cb80d989342fd9c  tenr-de-styles-pkg-1.0.tar.bz2
* own directories it creates
* sane provides
* %files section right
* not a gui app nor a library
* content, not code, but content acceptable in fedora extras

Is the Requires: fluxbox really right? Are those themes unusefull
for similar window managers? Wouldn't it make sense to allow
installing the themes, but not fluxbox, to use the pixmaps in another
possibly unrelated project? 

The Requires: fluxbox issue is not a blocker, the wrong permission 
is a blocker.

So, it is 

APPROVED

if you fix the permission issue. You can do it after importing to cvs, 
or before whatever you prefer.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.