[Bug 210087] Review Request: pekwm - Light weight window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pekwm - Light weight window manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210087


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-10-10 12:20 EST -------
There are some BR (BuildRequires) that may be missing:

libpng-devel libXinerama-devel libjpeg-devel 

Did you check the link flags in mock?

Why don't you enable pcre?

in files, you should have
%dir %{_datadir}/%{name}
otherwise the things within that dir are listed twice.

There is a dot missing in description.

Optionally you could shorten the summary by removing 'based on the 
aewm++ window manager'.

Are the
           --x-includes=%{_includedir} \
           --x-libraries=%{_libdir} \
really needed?

Could you expand a bit on            --sysconfdir=%{_datadir}
That seems a bit strange...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.