[Bug 210027] Review Request: bitmap - Bitmap editor and converter utilities for the X Window System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027





------- Additional Comments From pertusus at free.fr  2006-10-10 15:57 EST -------
(In reply to comment #4)
> First review of this package:

> * Requires:
>   Would you explain why this package should have
>   Provides: %{name}-devel = %{version}-%{release} ?

That's because the icons may be included, like regular include files
in some code. This is the same than for (xorg-x11-)xbitmaps-devel.

>   (If this must be as such, this package should also provide:
>    xorg-x11-%{name}-devel ?)

Indeed. Fixed.

> * Using %{buildroot} vs $RPM_BUILD_ROOT.
>   - Use one, not both.

Fixed.

> * File and Directory Ownership :
>   - %{_includedir}/X11/bitmaps/ is owned by xorg-x11-xbitmaps.
>     If this package requires xbitmaps (would you explain why?),
>     owning this directory is not needed for this package.

It requires xbitmap because it uses some bitmaps from there.
When you start the application without xbitmaps installed it 
complains about the missing bitmap.

I fixed the directory owning.

New srpm here:
http://www.environnement.ens.fr/perso/dumas/fc-srpms/bitmap-1.0.2-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.