[Bug 210087] Review Request: pekwm - Light weight window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pekwm - Light weight window manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210087





------- Additional Comments From pertusus at free.fr  2006-10-10 16:52 EST -------
(In reply to comment #2)

> No, how do I check that? What I did was went to the src dir and did a grep for
> includes. The one for xinerama came from X11/extensions/Xinerama.h so I did an
> rpmquery -f on /usr/include/X11/extensions/Xinerama.h and found it was provided
> by xorg-x11-proto-devel-7.0-6 
> I guess I just over looked the jpeg and png header files.

There is also the .so linked that are needed:
# rpm -qf /usr/lib/libXinerama.so
libXinerama-devel-1.0.1-2.1

> > Why don't you enable pcre?
> No reason, I guess I should build with all the options I guess?

Indeed. 

> No I guess not, but thats how the fluxbox package is done so I followed suit.

You can leave it if you prefer.

> > Could you expand a bit on            --sysconfdir=%{_datadir}
> > That seems a bit strange...
> 
> Yes, before doing this it would put all these files into /etc/pekwm and they
> really had no place there. rpmlint was complaining about it, and they seem to be
> better placed in /usr/share/pekwm to me. 

I've read a bit of doc, and it seems like the config files
are copied to the home as soon as possible. So it is not that 
important where the defaults are. The scripts would better be 
in /usr/share/pekwm or even in /usr/bin, but the 
config files may be in %_sysconfdir, in case the local sysadm wants to 
tailor the default config. In fluxbox it is in /usr/share, but I 
am not convinced it is right.

The theme is installed in /usr/share allready.

You can easily overwrite what is done by make in menu.in or 
config.in, by doing the sed which sets the path yourself. 

So my proposal is, keep sysconfdir as is, but move the 
scrips to %_bindir, and use sed yourself to regenerate menu from
data/menu.in.

A wild guess is that to put the scripts for example in %_bindir
you could just redefine scriptsdir on the make install command line.

Otherwise scripts use pkill from procps, and also there seems
to be a need for xprop, which is a virtual provides of 
xorg-x11-utils.

The default menu brings in a lot of dependencies. I am not convinced
what should be done there. Have a menu with wrong entries? Trim
it down and add requires? 

Would you feel like modifying fluxbox-xdg-menu, remove the footer
and header, change parseMenu to generate pekwm format, 
and remove the Submenus from Submenu = "Editors" to 
Submenu = "Development", and replace them by an entry like:
Entry = "" { Actions = "Dynamic %{bindir}/pekwm-xdg-menu" }?
This seems to be the best thing to do, currently it doesn't
really integrate with fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.