[Bug 210464] Review Request: anjuta-2 - A very capable IDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: anjuta-2 - A very capable IDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210464





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-14 07:20 EST -------
(In reply to comment #4)
> I want 2.0.2 in Rawhide only until it's stability is proven - that said, it's on
> 3 machines here and has only crashed once in 4 months. It will replace 1.2.4a
> once uploaded.
Then I think there is no reason that the spec file should have the name
"anjuta2.spec", as far as you think of this package as a normal upgrade
of anjuta-1.2.4a.

Well, I have not checked this precisely, however:
1. rpmlint is not silent.

W: anjuta devel-file-in-non-devel-package /usr/share/anjuta/project/gtk/src/main.c
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/anjuta-plugin/src/plugin.h
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/anjuta-plugin/src/plugin.c
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/xlib-dock/src/main.c
E: anjuta zero-length /usr/share/anjuta/project/cpp/AUTHORS
W: anjuta devel-file-in-non-devel-package /usr/share/anjuta/project/xlib/src/main.c
E: anjuta zero-length /usr/share/anjuta/project/terminal/po/ChangeLog
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/gtk/src/callbacks.h
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/gtk/src/callbacks.c
E: anjuta zero-length /usr/share/anjuta/project/cpp/po/ChangeLog
E: anjuta zero-length /usr/share/anjuta/project/cpp/NEWS
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/terminal/src/main.c
E: anjuta zero-length /usr/share/anjuta/project/terminal/NEWS
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/gnome/src/callbacks.c
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/gnome/src/callbacks.h
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/xlib-dock/src/wmgeneral.h
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/xlib-dock/src/wmgeneral.c
W: anjuta devel-file-in-non-devel-package /usr/share/anjuta/project/gnome/src/main.c
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/mkfile/src/main.c
E: anjuta zero-length /usr/share/anjuta/project/mkfile/po/ChangeLog
E: anjuta zero-length /usr/share/anjuta/project/terminal/README
W: anjuta devel-file-in-non-devel-package
/usr/share/anjuta/project/xlib-dock/src/pixmaps.h
E: anjuta zero-length /usr/share/anjuta/project/cpp/README
E: anjuta zero-length /usr/share/anjuta/project/cpp/ChangeLog
E: anjuta zero-length /usr/share/anjuta/project/terminal/ChangeLog
E: anjuta zero-length /usr/share/anjuta/project/terminal/AUTHORS
W: anjuta devel-file-in-non-devel-package /usr/share/anjuta/indent_test.c
E: anjuta invalid-spec-name anjuta2.spec
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/StyleContext.cxx
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/LexLisp.cxx
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/LexRuby.cxx
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/LexCrontab.cxx
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/LexAda.cxx
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/XPM.cxx
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/StyleContext.h
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/XPM.h
E: anjuta-debuginfo script-without-shebang
/usr/src/debug/anjuta-2.0.2/scintilla/LexEiffel.cxx

1-A Please explain why some "usually-in-devel" files should be in main package.
1-B The errors of "zero-length" files cannot be acceptable. Remove all these
     files (when the files become non-empty, add the files _THEN_ ).
1-C "script-without-shebang" in debuginfo rpm: permissions are incorrect.
     Fix these.
1-D invalid-spec-name: I think the name of spec file should be "anjuta.spec".

2. Clean up BuildRequires and Requires. I can see many redundant 
   (Build)Requires.
3. Please explain bliefly why Requires you added are needed.
4. Don't use %{buildroot} and ${RPM_BUILD_ROOT} both. Please use only one.
5. Also use "|| : " method to update-mime-database and redirect the result to
   /dev/null.
6. A package including pkgconfig configration file should require 
   "pkgconfig". Also, libanjuta-1.0.pc includes:
   Requires: libgnomeui-2.0 libglade-2.0. This means that -devel package should
   libgnomeui-devel and libglade2-devel.

(again note: I have not checked this package fully yet)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.