[Bug 206838] Review Request: TGFastData - Automatic user interface generation for TurboGears

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TGFastData - Automatic user interface generation for TurboGears


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206838





------- Additional Comments From tibbs at math.uh.edu  2006-10-14 11:51 EST -------
Hmm, I interpreted the above to mean that you were going to send along an
updated version.  But I'll go ahead and review -3 with the Source0: URL fixed
and see how it comes out.

The rpmlint warnings in comment #4 are present; I've found that not-zip-safe is
indeed a flag file and it seems that the egg-info junk really does need to be
packaged, so the zero-length-file bit is OK.  The no-documentation bit is
unfortunate, but you're not expected to write the documentation if it's not
already there.

There are tests, but there's no %check and I'm not sure if they can be run at
build time.  Is it possible to run them at all, even after the package is 
installed?  Otherwise I have no way to test this package.

The /usr/lib/python2.4/site-packages/tgfastdata/ directory is unowned, as are
all of the subdirectories of that directory.

You can probably just delete the empty %doc tag from %files.

* source files match upstream:
   523bdd96bda2f505c2626051a95565d4  TGFastData-0.9a6-py2.4.egg
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint has only acceptable complaints.
* final provides and requires are sane:
   python-tgfastdata = 0.9a6-3.fc6
  =
   python(abi) = 2.4
? %check is not present, but there are tests present.
X fails to own /usr/lib/python2.4/site-packages/tgfastdata and its subdirs.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* no docs at all to package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.