[Bug 205929] Review Request: libfreebob - FreeBoB firewire audio driver library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libfreebob - FreeBoB firewire audio driver library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205929





------- Additional Comments From kevin at tummy.com  2006-10-14 13:18 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
aa550528324a4dfb3cf7c9a90d83c694  libfreebob-1.0.0.tar.bz2
aa550528324a4dfb3cf7c9a90d83c694  libfreebob-1.0.0.tar.bz2.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.
OK - Package compiles and builds on at least one arch.
See below - Package has no duplicate files in %files.
OK - Package owns all the directories it creates.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.              
i386/x86_64 - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. You seem to be including the docs in both the main package
and the -devel package. Perhaps just have them in the main package
files?

2. rpmlint says:

W: libfreebob-devel summary-ended-with-dot Libraries, includes etc to develop 
with libfreebob.

Might remove the trailing . to make rpmlint happy. ;)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.