[Bug 210217] Review Request: pygpgme - Python module for working with OpenPGP messages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pygpgme - Python module for working with OpenPGP messages


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210217





------- Additional Comments From mr.ecik at gmail.com  2006-10-14 15:36 EST -------
MUST items:
 * rpmlint output:
E: pygpgme unknown-key GPG#cd84ee48
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with an LGPL (?) open-source compatible license
 * License field in spec file matches (?) actual license
 * license file isn't included in %doc
 * md5sums are matching (0878d866b6ee8a98a9003a81934ecee3)
 * package successfully compiles on x86_64
 * BuildRequires look listed well (but I haven't tried to build in mock)
 * no locales
 * no need to %post and %postun sections
 * not relocatable
 * package owns directories well
 * no duplicates in %files
 * every %files section includes %defattr
 * proper %clean section
 * macros used well

Package looks good, but I'm not sure if rpmlint is a blocker (maybe
someone more experienced will express his opinion?).
The another problem is lack of license file in %doc, but according
to guidelines: "If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc" so that's not a problem.
And the last thing is package license. You've written LGPL as license
but I couldn't find any information about that (no COPYING, nothing on
website) so please show me reliable source where I can find license info.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.