[Bug 210323] Review Request: perl-File-DesktopEntry - Object to handle .desktop files
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 14 19:56:44 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-10-14 15:56 EST -------
Michael, everything on http://fedoraproject.org/wiki/Packaging/Perl is either
advisory or contingent on the faulure of some part of RPM's automatic dependency
generation. RPM actually does a pretty good job of figuring out most Perl
dependencies, and the resulting packages don't generally need much in the way of
extraneous bits.
* source files match upstream:
9c97efa062c04bcb86a0a6a3707355d1 File-DesktopEntry-0.02.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
perl(File::DesktopEntry) = 0.02
perl-File-DesktopEntry = 0.02-1.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(File::Spec)
perl(strict)
* %check is present and all tests pass:
All tests successful.
Files=2, Tests=10, 0 wallclock secs ( 0.06 cusr + 0.03 csys = 0.09 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list