[Bug 200422] Review Request: international-time (first package, seeking sponsor)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: international-time (first package, seeking sponsor)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200422


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-10-14 16:29 EST -------
Hey Tim. Here's a review... 


OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - BuildRequires correct
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
i386/x86_64 ok - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
See below - Should package latest version

Issues:

1. Is there an upstream Source0 URL where this is available?
Are you the upstream author?

2. Can you include some kind of license information or files?
If it's GPL, might include a COPYING file and perhaps note that it's
distributed under the GPL in a README or in the source files?

3. You might change the default perms from:
%defattr(-,root,root)
to
%defattr(-,root,root,-)

4. rpmlint says:

W: international-time no-url-tag
W: international-time no-documentation

5. It seems to run fine here, but I get the following warning: 

(international-time:4464): libglade-WARNING **: could not find glade file 
'international-time.glade'


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.