[Bug 210322] Review Request: perl-File-MimeInfo - Determine file type

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-File-MimeInfo - Determine file type


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210322


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-10-14 16:51 EST -------
I have placed the two build dependencies in a local repo in order to build this.

* source files match upstream:
   f87b07e1608f4380bb3f53154ac671bb  File-MimeInfo-0.13.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(File::MimeInfo) = 0.13
   perl(File::MimeInfo::Applications) = 0.02
   perl(File::MimeInfo::Magic) = 0.12
   perl(File::MimeInfo::Rox) = 0.2
   perl-File-MimeInfo = 0.13-1.fc6
  =
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Exporter)
   perl(Fcntl)
   perl(File::BaseDir)
   perl(File::DesktopEntry)
   perl(File::MimeInfo)
   perl(File::Spec)
   perl(strict)
* %check is present and all tests pass:
   All tests successful.
   Files=5, Tests=58,  0 wallclock secs ( 0.18 cusr +  0.08 csys =  0.26 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.