[Bug 210775] Review Request: Eternal Lands - a free MMORPG

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Eternal Lands - a free MMORPG


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210775


mr.ecik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mr.ecik at gmail.com




------- Additional Comments From mr.ecik at gmail.com  2006-10-14 17:32 EST -------
Maybe I'll make a review tommorow (but I'm not sure), but I see a few faults
here, in spec file.

 1) Why do you use "-n eternallands-%{version}" parameter to %setup macro?
By default, rpm tries to change directory to %{name}-%{version}.

 2) I think that inclusion wrapper as an another source would be better than
creating it in spec file (only imho).

 3) data files shouldn't go into %{_datadir}/games/%{name}, but
%{_datadir}/%{name}. Read http://fedoraproject.org/wiki/Extras/SIGs/Games
for further information.

 4) post scripts look wrongly (read http://fedoraproject.org/wiki/
PackagingDrafts/ScriptletSnippets)

And the last thing: creation of your own tarball may be a problem to a reviewer.
I think you should include all tarballs as sources and make any required
modifictions in %prep section and/or patches.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.