[Bug 190343] Review Request: VDR - Video Disk Recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: VDR - Video Disk Recorder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190343


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-10-14 19:51 EST -------
I'll take a stab at a review on this: 

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
9bb82d1f090dad746d784d147dbb0126  vdr-1.4.3.tar.bz2
9bb82d1f090dad746d784d147dbb0126  vdr-1.4.3.tar.bz2.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
OK - .pc files in -devel subpackage/requires pkgconfig
See below - -devel package Requires: %{name} = %{version}-%{release}
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
See below - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
i386/x86_64 - Should build on all supported archs
See below - Should have subpackages require base package with fully versioned 
depend.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Shouldn't the -devel subpackage require:
Requires: %{name} = %{version}-%{release}
(And/Or perhaps the api version since you know it?)

2. Should these be even packaged since they don't contain anything:
%{_libdir}/vdr
%{_libdir}/bin
%{_datadir}/vdr
%{_datadir}/vdr/logos
Or are they needed for some of the other packages that depend on this one?

3. rpmlint says:

W: vdr conffile-without-noreplace-flag /etc/security/console.perms.d/95-
vdr.perms
(The note in the spec file explains this one)

E: vdr non-standard-uid /etc/vdr/diseqc.conf vdr
E: vdr non-standard-gid /etc/vdr/diseqc.conf video
E: vdr non-standard-uid /etc/vdr/reccmds.conf vdr
E: vdr non-standard-gid /etc/vdr/reccmds.conf video
E: vdr non-standard-uid /etc/vdr/themes vdr
E: vdr non-standard-gid /etc/vdr/themes video
E: vdr non-standard-uid /var/cache/vdr vdr
E: vdr non-standard-gid /var/cache/vdr video
E: vdr non-standard-uid /var/lib/vdr vdr
E: vdr non-standard-gid /var/lib/vdr video
E: vdr non-standard-uid /srv/audio vdr
E: vdr non-standard-gid /srv/audio video
E: vdr non-standard-uid /etc/vdr/themes/classic-default.theme vdr
E: vdr non-standard-gid /etc/vdr/themes/classic-default.theme video
E: vdr non-standard-uid /etc/vdr/remote.conf vdr
E: vdr non-standard-gid /etc/vdr/remote.conf video
E: vdr non-standard-uid /var/cache/vdr/epg.data vdr
E: vdr non-standard-gid /var/cache/vdr/epg.data video
E: vdr non-standard-uid /etc/vdr/timers.conf vdr
E: vdr non-standard-gid /etc/vdr/timers.conf video
E: vdr non-standard-uid /srv/vdr vdr
E: vdr non-standard-gid /srv/vdr video
E: vdr non-standard-uid /etc/vdr vdr
E: vdr non-standard-gid /etc/vdr video
E: vdr non-standard-uid /etc/vdr/channels.conf vdr
E: vdr non-standard-gid /etc/vdr/channels.conf video
E: vdr non-standard-uid /etc/vdr/themes/sttng-default.theme vdr
E: vdr non-standard-gid /etc/vdr/themes/sttng-default.theme video
E: vdr non-standard-uid /etc/vdr/svdrphosts.conf vdr
E: vdr non-standard-gid /etc/vdr/svdrphosts.conf video
E: vdr non-standard-uid /etc/vdr/keymacros.conf vdr
E: vdr non-standard-gid /etc/vdr/keymacros.conf video
E: vdr non-standard-uid /etc/vdr/sources.conf vdr
E: vdr non-standard-gid /etc/vdr/sources.conf video
E: vdr non-standard-uid /etc/vdr/setup.conf vdr
E: vdr non-standard-gid /etc/vdr/setup.conf video
E: vdr non-standard-uid /etc/vdr/plugins vdr
E: vdr non-standard-gid /etc/vdr/plugins video
E: vdr non-standard-uid /var/run/vdr vdr
E: vdr non-standard-gid /var/run/vdr video
E: vdr non-standard-uid /etc/vdr/commands.conf vdr
E: vdr non-standard-gid /etc/vdr/commands.conf video

All those can be ignored most likely.

W: vdr incoherent-subsys /etc/rc.d/init.d/vdr $prog

Something going on with the init sript or pid file?

E: vdr-devel only-non-binary-in-usr-lib

This can be ignored, there are binaries in /usr/sbin, so
this can't be noarch.

W: vdr non-conffile-in-etc /etc/sysconfig/vdr-plugins.d/README

This README is probibly needed to explain the plugins?

E: vdr zero-length /etc/vdr/remote.conf
E: vdr zero-length /etc/vdr/setup.conf
E: vdr zero-length /etc/vdr/channels.conf
E: vdr zero-length /etc/vdr/timers.conf 

Your note in the spec explains these.  


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.