[Bug 204166] Review Request: xeuphoric - an X based Oric emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xeuphoric - an X based Oric emulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204166





------- Additional Comments From tibbs at math.uh.edu  2006-10-14 20:32 EST -------
That typo in the URL is still there.

rpmlint has some complaints:
W: xeuphoric file-not-utf8 /usr/share/man/man1/xeuphoric.1.gz
   Indeed it isn't, probably due to a single character in the author's name.
W: xeuphoric non-conffile-in-etc /etc/xeuphoric/0.18.2/xeuphoricrc
   This needs to be marked %config.
E: xeuphoric configure-without-libdir-spec
   This is bogus; the configure script was not generated by autotools.
W: xeuphoric-roms no-documentation
   Not a problem.

So two valid complaints there.

The flags passed to the compiler seem to be "-DX11 -g -Wall -O3", which are
incorrect.  This is fixable by changing the make line to:
   make CFLAGS="-DX11 %{optflags}" %{?_smp_mflags}
The resulting executable seems to work fine.

I wonder if the base package shouldn't require the roms package, instead of the
other way around.  Normally you'd just install xeuphoric and have it pull in the
roms; currently if you do that you get something that doesn't work too well.

Review:
* source files match upstream:
   4a2469ee45d6476350ffc0a92d165990  xeuphoric-0.18.2.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not appropriate.
* %clean is present.
* package builds in mock (development, i386).
* package installs properly
* debuginfo package looks complete.
X rpmlint has valid complaints.
? final provides and requires are sane:
  xeuphoric-0.18.2-3.fc5.i386.rpm
   xeuphoric = 0.18.2-3.fc5
  =
   libX11.so.6
   libXext.so.6
   libartsc.so.0

  xeuphoric-roms-0.18.2-3.fc5.i386.rpm
   xeuphoric-roms = 0.18.2-3.fc5
  =
   xeuphoric = 0.18.2-3.fc5

* %check is not present; no test suite upstream.  Package manually tested and
found to be OK.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
X GUI app, but no desktop file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.