[Bug 210464] Review Request: anjuta-2 - A very capable IDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: anjuta-2 - A very capable IDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210464





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-15 13:15 EST -------
Well, about BuildRequires: 
I wonder why you want to list many redundant lists. Among your
BuildRequires list:

glib2-devel              <- required by gtk2-devel
gtk2-devel               <- required by libglade2-devel
ORBit2-devel             <- required by libbonoboui-devel
libglade2-devel          <- required by libgnomeui-devel
libgnome-devel           <- required by libbonoboui-devel
libgnomeui-devel         <- required by devhelp-devel
libgnomeprint22-devel    <- required by libgnomeprintui22-devel
libgnomeprintui22-devel
gnome-vfs2-devel         <- required by libgnome-devel
libbonobo-devel          <- required by libgnome-devel
libbonoboui-devel        <- required by libgnomeui-devel
vte-devel
libxml2-devel            <- required by libgnomeui-devel
pango-devel              <- required by gtk2-devel
pcre-devel
devhelp-devel
anjuta-gdl-devel
gnome-build-devel
graphviz-devel
neon-devel
scrollkeeper
perl(XML::Parser)
autogen-devel            = This should be "autogen". autogen-devel seems
unnecessary.
gettext-devel            = This should be "gettext". gettext-devel seems
unnecessary.
gtksourceview-devel      <- 
pkgconfig                <- required by glib2-devel

All the BuildRequires followed by "<- requied by ..." are not necessary
because other BuildRequires also require them.

Also, mockbuild fails.

make[3]: Entering directory `/builddir/build/BUILD/anjuta-2.0.2/tagmanager'
if /usr/bin/libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I..
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -I./include   -O0 -g
-Wall -Wmissing-prototypes -Wmissing-declarations -Wparentheses -Wpointer-arith
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -MT args.lo -MD -MP -MF ".deps/args.Tpo" -c -o
args.lo args.c; \
        then mv -f ".deps/args.Tpo" ".deps/args.Plo"; else rm -f
".deps/args.Tpo"; exit 1; fi
/bin/sh: /usr/bin/libtool: No such file or directory
make[3]: *** [args.lo] Error 1
make[3]: Leaving directory `/builddir/build/BUILD/anjuta-2.0.2/tagmanager'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/anjuta-2.0.2/tagmanager'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/anjuta-2.0.2'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.12427 (%build)

Add "libtool" to BuildRequires.

Then:

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

* Changelogs
  - By the way, why does this package have EPOCH 1?

* Requires
  - Requires(post): scrollkeeper
    Requires(postun): scrollkeeper
    These are for -docs subpackage, not for main.
  - Requires for -devel
    libglade-devel should be "libglade2-devel".

* BuildRequires
  - Described above.
  - By the way, why does this package disable subversion support?
    (I don't know well about this package).

* Encodings
  - Some files are encoded in unwilling charsets.
  * At least change the encodings of following files to UTF-8.
    /usr/share/doc/anjuta/THANKS ISO-8859-1 in anjuta

* Timestamps
  - These packages many header files, HTML documents, image files and etc.
    These files are originally in source tarball and not modified during
    building these packages.
    For this case, keeping timestamps is highly recommended to show when
    these files are created. Keep the timestamps of these files.

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   = Nothing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.