[Bug 210823] Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210823





------- Additional Comments From ed at eh3.com  2006-10-15 16:58 EST -------
Hi Mola, this is by no means a thorough review--just a quick list of 
observations:

needswork:
 - spec file contains a mix of spaces and tabs--please cleanup
 - please consider deleting "Prefix: %{_prefix}"
 - dir %{_includedir}/wxXML appears to be unowned
 - please consider deleting or excluding the static libs
 - why is %{_libdir}/libwxsvg.la both listed as a file and
     also as an %exclude item?
 - usually, all *.so files go in the -devel sub-package and the 
     *.so.* files go in the main package
 - please add "%defattr(-,root,root,-)" to the "%files devel" section
 - the license type needs to be more specific (it appears to be the 
     wxWindows Library Licence, Version 3)
 - the "%doc" section should, at a min, contain the COPYING file
 - neither of the two Summary:-ies should end in a "."

Please take a close look at:

  http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

and run "rpmlint" against this package (both the SRPM and the various 
binary rpms) before posting an updated SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.