[Bug 190029] Review Request: whysynth-dssi - DSSI software synthesizer plugin

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 17 11:03:16 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029





------- Additional Comments From opensource at till.name  2006-10-17 07:03 EST -------
The categories can be added directly to the .desktop file:

  --add-category AudioVideo                       \
  --add-category Application                      \

These Requires should not be used
(http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda)
Requires(post):   desktop-file-utils
Requires(postun): desktop-file-utils

Here you make a symlink (cd $RPM_BUILD_ROOT%{_bindir}; ln -s jack-dssi-host
whysynth) but in the fluidsynth-dssi package you did not. I do not really know,
whether or not it is needed but from a user's point of view I think it is better
to be consistent here and either add these symlink or not for dssi plugins.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list