[Bug 210087] Review Request: pekwm - Light weight window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pekwm - Light weight window manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210087





------- Additional Comments From pertusus at free.fr  2006-10-17 16:13 EST -------
The rpmlint error is ignorable. This executable in etc is 
something we want.

I still think that the summary would be better without
'based on the aewm++ window manager', but it is not a blocker.

The dot missing at the end of the %description is a blocker
(although one easy to fix).

Not a blocker, but I would have requires xprop and not xorg-x11-utils.
 
What about the procps Requires?

* rpmlint gives
E: pekwm executable-marked-as-config-file /etc/pekwm/start
which is ignorable.
* free software. License not included, should be asked upstream, 
  especially since in files it is referred to that file.
* name right
* follow guidelines
* spec legible
* build on x86
* buildrequires mostly right, missing pcre-devel
* sane provides:
Provides: config(pekwm) = 0.1.5-3
* files right except for an unowned directory
* source match upstream:
fe3e0d77250d27963991994f83ccb4ea  pekwm-0.1.5.tar.bz2

MUSTFIX:
unowned directory, must add
%dir %{_datadir}/%{name}/themes/

dot at end of %description

BR pcre-devel

SHOULDFIX:
handle properly UTF-8. I won't make it a bloker, but having a
graphical app which don't accept UTF8 accents in menu is not
right in fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.