[Bug 211242] Review Request: scribes-templates - Templates ("Snippets") for the Scribes text editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scribes-templates - Templates ("Snippets") for the Scribes text editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211242


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: scribes-    |Review Request: scribes-
                   |templates - Templates       |templates - Templates
                   |("Snippets") for the Scribes|("Snippets") for the Scribes
                   |text editor                 |text editor
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-18 11:43 EST -------
1.
Well, while writing  %build section seems preferable even if
it is empty, don't write %pre %preun.. etc if they are empty because
writing "%post" (even if its content is empty) calls a shell 
(in this case, it is /bin/bash) without autual need 
and adds redundant "Requires: /bin/bash" to the rpm package.
2.
The line: install -m 0644 %{SOURCE1} .
Please keep timestamps, i.e. use "install -p" (or "cp -p").
3.
By the way, does upstream have a plan to change the numbering of
"VERSION"? Usually writing date to version is not preferable.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.