[Bug 205755] Review Request: elsa - manages group of processes and allows accounting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elsa - manages group of processes and allows accounting


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205755





------- Additional Comments From konradr at redhat.com  2006-10-18 17:13 EST -------
1). 
Source0:        elsa-1.3.0.tar.bz2

You should use %{version}-%{release} instead of hard-coded numbers

2).
%build
make %{?_smp_mflags} USER_INCLUDES=-I%{cn_proc_dir}

You are not using %{optflags} which can provide extra compile flags for Fedora
packages. 

To pass them along you can use the CFLAGS env variable, as so:

CFLAGS="%{optflags}"  make %{?_smp_mflags} USER_INCLUDES=-I%{cn_proc_dir}

3)

/bin/*
/sbin/*
/usr/share/man/man1/*

Should be:
%{_bindir}/<files or globs>
%{_sbindir)/<files or globs>
${_mandir}/man1/elsa*

4)
%doc -P ChangeLog COPYING README HOWTO utils/test_elsa_installation.sh

Is the .sh file executable in the source tar ball?

5).
if [ ! -f %{cn_proc_file} ]; then
  echo " ERROR: %{cn_proc_file} not found"
  echo " EXIT "
  exit 1
fi

Is this check needed?  You have:
BuildRequires:  kernel-devel >= 2.6.15

which will provide that package and that header file.
Consequently, these will not be required:

%define kversion `uname -r`
%define cn_proc_dir /lib/modules/%{kversion}/build/include
%define cn_proc_file %{cn_proc_dir}/linux/cn_proc.h

Also, the 'uname -r' is not a good check - as the build machines
does not have to be neccesarily the same version as what the Fedora release
kernel would have. (FC6 is actually compiled on RHEL4 machines)

And lastly this  "USER_INCLUDES=-I%{cn_proc_dir}" wouldn't be needed either.

Let me find out from other third-party spec files what the correct way of
finding kernel header files is.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.