[Bug 205755] Review Request: elsa - manages group of processes and allows accounting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elsa - manages group of processes and allows accounting


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205755





------- Additional Comments From guillaume.thouvenin at bull.net  2006-10-19 05:07 EST -------
(In reply to comment #3)
> 1). 
> Source0:        elsa-1.3.0.tar.bz2
> 
> You should use %{version}-%{release} instead of hard-coded numbers

Done

> 2).
> To pass them along you can use the CFLAGS env variable, as so:
> 
> CFLAGS="%{optflags}"  make %{?_smp_mflags} USER_INCLUDES=-I%{cn_proc_dir}

Done.

> 3)
> 
> /bin/*
> /sbin/*
> /usr/share/man/man1/*
> 
> Should be:
> %{_bindir}/<files or globs>
> %{_sbindir)/<files or globs>
> ${_mandir}/man1/elsa*

Replaced. So now elsa and jobmng are installed in the '/usr/bin' directory and
jobd is installed in the '/usr/sbin' directory.


> 4)
> %doc -P ChangeLog COPYING README HOWTO utils/test_elsa_installation.sh
> 
> Is the .sh file executable in the source tar ball?

Yes it is. 

> 5).
> if [ ! -f %{cn_proc_file} ]; then
>   echo " ERROR: %{cn_proc_file} not found"
>   echo " EXIT "
>   exit 1
> fi
> 
> Is this check needed?  You have:
> BuildRequires:  kernel-devel >= 2.6.15

Yes, you're right. I removed this test.

> %define kversion `uname -r`
> %define cn_proc_dir /lib/modules/%{kversion}/build/include
> %define cn_proc_file %{cn_proc_dir}/linux/cn_proc.h

I replaced this one:

%define kversion `rpm -q kernel-devel | cut --delimiter='-' -f 3,4` 

and thus, in %build stage I have:

CFLAGS="%{optflags}" make %{?_smp_mflags}  \
USER_INCLUDES=-I/usr/src/kernels/%{kversion}-%{_host_cpu}/include

I'm not sure if this is the right way to proceed?

Spec URL and SRPM URL are the same so to check changes you can still use them.
Thank you very much for all your comments,

Guillaume

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.