[Bug 210007] Review Request: <libtune> - <standard API to access the kernel tunables>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <libtune> - <standard API to access the kernel tunables>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007





------- Additional Comments From Nadia.Derbey at bull.net  2006-10-19 10:27 EST -------
(In reply to comment #3)
> 1).
> You are not using the Release tag everywhere.

It's true that I used to "play" with the version numbers, but reading the
"naming guidelines" I'm realizing that using the release tag may be sometimes
more appropriate!

to be fixed


> 
> 2). 
> 
> %description -n tunables-data-SLES9-2.6.5
> This package supplies the tunables database for SuSE Linux Enterprise Server
> 9's 2.6.5
> ....
> %description -n .. FC2/FC3/etc
> 
> This package is for RHEL5/FC5,6. There is no need for these descriptions.
> Remove them and leave the one for FC5,6.

The only thing I regret in removing the older releases is that having FC3 and
FC4 used to show how the library can be useful, with "exec-shield-randomize"
moving to "randomize_va_space" from FC3 to FC4 :-(

To be fixed

> 3). %{optflags} / %{?_smp_mflags}

To be fixed

> 
> 4).
> %{_libdir}/libtune.la
> %{_libdir}/libtune.so.0
> %{_libdir}/libtune.so.0.0.0
> 
> you can glob them using the *
> 

Doing this I would get libtune.a and libtune.so too, while these 2 files have
to go in the -devel package. Am I wrong?

> 5).
> 
> %post devel
> /sbin/chkconfig --add chtunedb
> /sbin/ldconfig
> 
> You should have 'ldconfig' before running chkconfig.

The service to be added (chtundb) doesn't use the library.
So I think that using that ordering or the one you propose is equivalent
(or may be I missed something?)

> 
> 6). ldconfig -n

To be fixed

> 
> 7).
> %preun devel
> /sbin/chkconfig --del chtunedb
> 
> you probably should also check if the service is running (or just asssume it is
> ) before deleting it.
> 
> /sbin/service chtunedb stop > /dev/null 2>&1
> /sbin/chkconfig --del chtunedb
> 
> Would do nicely.
> 

Actually, chtundb is run once at boot time: it just checks that the tunables
databases are coherent with the running kernel, then it leaves. That's why I 
think there is no need to stop it before removing it. But if you think it
is better to do it the "standard way", I can fix this anyway.

> 
> 8). Missing Requires:

To be fixed

> 
> 9)
> Run 'rpmlint' on your SRPM. Fix all of the errors.

I used and old version of rpmlint that was silent...
Sorry!

To be fixed



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.