[Bug 210790] Review Request: dar - Collection of scripts for making/restoring CD/DVD backups

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 19 16:45:16 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dar - Collection of scripts for making/restoring CD/DVD backups


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210790


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-19 12:45 EST -------
1.
Well, static binary is strictly forbidden in fedora.
1-A please explain why it is needed (note: even if you explain why,
     perhaps most reviewers including me will not accept it).
1-B I don't know well about NSS service, however, static binary in this
     package seems meaningless anyway because you can see in the build log:

/builddir/build/BUILD/dar-2.3.1/src/libdar/.libs/libdar.a(tools.o): In function
`libdar::tools_name_of_gid(unsigned short)':
/builddir/build/BUILD/dar-2.3.1/src/libdar/tools.cpp:416: warning: Using
'getgrgid' in statically linked applications requires at runtime the sh
ared libraries from the glibc version used for linking
/builddir/build/BUILD/dar-2.3.1/src/libdar/.libs/libdar.a(tools.o): In function
`libdar::tools_name_of_uid(unsigned short)':
/builddir/build/BUILD/dar-2.3.1/src/libdar/tools.cpp:402: warning: Using
'getpwuid' in statically linked applications requires at runtime the sh
ared libraries from the glibc version used for linking

* Similarly, please explain why %{_libdir}/*.a is necessary (as said above,
  even if you explained why, it won't be accepted unless there is quite a
  reasonable reason).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list