[Bug 211551] Review Request: fluxter - a pager for use in fluxbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluxter - a pager for use in fluxbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211551





------- Additional Comments From miker5slow at grandecom.net  2006-10-19 19:45 EST -------
(In reply to comment #1)
> * You don't need to set CFLAGS, they are set by %configure.
> 
OK
> * if you add --enable-debug to %configure, the -s isn't added
> and the debuginfo package is created.

OK Ill do this

> * Why do you change fluxbox to fluxter in Makefiles? The fluxter
> files seems to live happily in %{_datadir}/fluxbox. Even if fluxter
> is usefull without fluxbox.

Well I dont have a solid answer for that, I just figured someone would look
there for the configs before they looked in the fluxbox dir for them
 
> * Missing Buildrequires, I spotted libX11-devel and libSM-devel.
isnt libX11-devel brought in by the xorg-x11-proto-devel BR?


> * is the Requires fluxbox really needed? Doesn't it work with other 
> wm?
See comment #3
 
> * No need to have the package name in the summary. 

OK


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.