[Bug 211043] Review Request: vdradmin-am - Web interface for VDR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdradmin-am - Web interface for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211043


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-10-19 22:58 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
b3f862dfa078bdef05b52a841850c65a  vdradmin-am-3.4.7.tar.bz2
b3f862dfa078bdef05b52a841850c65a  vdradmin-am-3.4.7.tar.bz2.1
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. rpmlint says:

You've addressed these in the bug, but a few comments:

E: vdradmin-am non-standard-uid /var/cache/vdradmin vdradmin
E: vdradmin-am non-standard-gid /var/cache/vdradmin vdradmin
E: vdradmin-am non-standard-uid /var/log/vdradmin vdradmin
E: vdradmin-am non-standard-gid /var/log/vdradmin vdradmin
E: vdradmin-am non-standard-uid /var/lib/vdradmin/vdradmind.conf vdradmin
E: vdradmin-am non-standard-gid /var/lib/vdradmin/vdradmind.conf vdradmin
E: vdradmin-am non-readable /var/lib/vdradmin/vdradmind.conf 0640
E: vdradmin-am non-standard-uid /var/lib/vdradmin vdradmin
E: vdradmin-am non-standard-gid /var/lib/vdradmin vdradmin
E: vdradmin-am non-standard-uid /var/run/vdradmin vdradmin
E: vdradmin-am non-standard-gid /var/run/vdradmin vdradmin
W: vdradmin-am log-files-without-logrotate /var/log/vdradmin

If the log files were enabled would they provide any usefull information?

W: vdradmin-am dangerous-command-in-%postun rm

I wish there was a way to avoid this. Is the cache directory multi-level?
or single directory of files? If so, you can remove the -r from the rm at
least.

W: vdradmin-am incoherent-subsys /etc/rc.d/init.d/vdradmind $prog
W: vdradmin-am incoherent-init-script-name vdradmind

2. Should this package require 'httpd' or 'webserver' ?

3. Should the description mention that you need a vdr install somewhere in 
order for this package to be usefull?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.