[Bug 211548] Review Request: fluxstyle - Graphical style manager for fluxbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluxstyle - Graphical style manager for fluxbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211548


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-10-20 04:49 EST -------
* There are missing:

%dir %{_datadir}/%{name}-%{version}/glade/
%dir %{_datadir}/%{name}-%{version}/images/

* The .desktop file don't seem very right to me:

- the MimeType seems very wrong
- In the categories, tere should certainly de somthing like
  System or Utilities.
- Icon entry is missing (and no icon is packaged)
  If the icon is fluxbox48x48-trans-metal-bevel.png, it should be
  copied to hicolor theme/48x48..... and the scriptlets should be 
  called.

* I am not convinced that fluxStyle.p* is rightly  in 
  /usr/lib/python2.4/site-packages/fluxstyle/, since it seems to be the
  same than the fluxStyle script in %_bindir. Am I missing something?

* I don't thtink the shebang of
/usr/lib/python2.4/site-packages/fluxstyle/__init__.py is right.
  It seems to me that it shouldn't have a shebang, and shouldn't be
  executable.

I am not very knowledgable in python so the last 2 comments may be 
wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.