[Bug 211626] Review Request: xtide - Calculate tide all over the world

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xtide - Calculate tide all over the world


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-10-21 09:49 EST -------
It seems to me that it should be (with 0 instead of 1)
%define          libtcd_rel       0.%{fedora_rel}
%define          tcdutils_rel     0.%{fedora_rel}.date%{tcdutils_date2}



For libtcd
instead of 
export CC="gcc `rpm --eval %%optflags` -DCOMPAT114"
there should be something along 
%{__make} %{?_smp_mflags} \
  OPTFLAGS="$RPM_OPT_FLAGS -DCOMPAT114" \
......

For xtide
-L/usr/lib shouldn't be there, it is allready on the linker path.
(and anyway it should be -L%{_libdir})
-L./libtcd is certainly unneeded in extracxxflags

`rpm --eval %%optflags` should be replaced by %{optflags}, rpm
shouldn't be called explicitely.

The 
/sbin/ldconfig $(pwd)/libtcd || :
is very dubious. In my opinion it shouldn't be there.

You should use consistently %optflags and $RPM_BUILD_ROOT.

I propose the following for tcd-utils:
%{__make} %{?_smp_mflags} \
  CXXFLAGS="$RPM_OPT_FLAGS -I../libtcd -DCOMPAT114" \
  CFLAGS="$RPM_OPT_FLAGS -I../libtcd -DCOMPAT114" \
  LDFLAGS="-L../libtcd"
together with the modified tcd-utils-1.3.7-shared.patch I'll attach,
which adds LDFLAGS. 

I don't see why the somajor/minor/ver should be different from 0.0.0.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.