[Bug 190029] Review Request: whysynth-dssi - DSSI software synthesizer plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029





------- Additional Comments From green at redhat.com  2006-10-21 14:26 EST -------
(In reply to comment #11)
> The categories can be added directly to the .desktop file:
> 
>   --add-category AudioVideo                       \
>   --add-category Application                      \
> 
> These Requires should not be used
>
(http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda)
> Requires(post):   desktop-file-utils
> Requires(postun): desktop-file-utils

Fixed and fixed.

> Here you make a symlink (cd $RPM_BUILD_ROOT%{_bindir}; ln -s jack-dssi-host
> whysynth) but in the fluidsynth-dssi package you did not. I do not really know,
> whether or not it is needed but from a user's point of view I think it is better
> to be consistent here and either add these symlink or not for dssi plugins.

I didn't do the same for fluidsynth because qsynth in Extras already serves 
same purpose as a fluidsynth jack-dssi-host link.  There is no
equivalent for whysynth.

New bits are here.  Thanks!

Spec URL: http://people.redhat.com/green/FE/devel/whysynth-dssi.spec
SRPM URL: http://people.redhat.com/green/FE/devel/whysynth-dssi-20060122-7.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.